This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Retiarii] Use ValueChoice inline in a serializable instance #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
approved these changes
Feb 22, 2021
|
@ultmaster looks great. please update doc accordingly |
94 tasks
liuzhe-lz
reviewed
Feb 24, 2021
nni/retiarii/graph.py
Outdated
| @@ -152,6 +152,14 @@ def _dump(self) -> Any: | |||
| } | |||
| return ret | |||
|
|
|||
| def get_nodes(self) -> List['Node']: | |||
There was a problem hiding this comment.
The return type is Iterable in this case.
liuzhe-lz
reviewed
Feb 24, 2021
nni/retiarii/nn/pytorch/api.py
Outdated
| @@ -237,6 +273,13 @@ def forward(self): | |||
| warnings.warn('You should not run forward of this module directly.') | |||
| return self.candidates[0] | |||
|
|
|||
| def __translate__(self): | |||
There was a problem hiding this comment.
Is it proper to use __xxx__ for non-builtin method name? I'm not sure.
liuzhe-lz
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Work items