This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix Windows UT #3065
Merged
Fix Windows UT #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzhe-lz
changed the title
added 11 commits
November 5, 2020 12:18
liuzhe-lz
changed the title
liuzhe-lz
requested review from
SparkSnail and
chicm-ms
and removed request for
SparkSnail
SparkSnail
reviewed
Nov 6, 2020
| @@ -34,8 +34,7 @@ def check_output_command(file_path, head=None, tail=None): | |||
| def kill_command(pid): | |||
| """kill command""" | |||
| if sys.platform == 'win32': | |||
| process = psutil.Process(pid=pid) | |||
| process.send_signal(signal.CTRL_BREAK_EVENT) | |||
| psutil.Process(pid).terminate() | |||
There was a problem hiding this comment.
For windows platform, main.ts monitor SIGBREAK signal to trigger stop process, does this terminate() function in win32 trigger SIGBREAK?
SparkSnail
approved these changes
Nov 9, 2020
chicm-ms
approved these changes
Nov 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR in fact contains 3 updates, sorry...