Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix installation in conda #3063

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Conversation

liuzhe-lz
Copy link
Contributor

@liuzhe-lz liuzhe-lz commented Nov 4, 2020

setuptools' develop --user does not work with conda, so use "global" install when conda or venv/virtualenv is detected.
Also added --no-user option in case detection fails.

It was reported that the copied node.js runtime does not have executable permission. Try to fix it by using shutil.copy(), which is said to "copies the file data and the file’s permission mode". Not tested on all platforms though.

@ultmaster ultmaster merged commit 16dc45b into microsoft:master Nov 5, 2020
@ultmaster ultmaster mentioned this pull request Nov 5, 2020
chicm-ms pushed a commit to chicm-ms/nni that referenced this pull request Nov 9, 2020
* fix install in conda

* copy node.js permission mode

* bugfix
@liuzhe-lz liuzhe-lz deleted the fix-install branch November 23, 2020 03:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants