This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add timeout for web_channel in trial_runner #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
merge master
merge master
merge master
merge master
merge master
merge master
Chinese translation (microsoft#2458)
merge master
This reverts commit c5e26ef.
squirrelsc
reviewed
Jul 22, 2020
tools/nni_trial_tool/web_channel.py
Outdated
| self.client = client | ||
| nni_log(LogType.Info, 'WebChannel: connected with info %s' % url) | ||
| except asyncio.TimeoutError: | ||
| nni_log(LogType.Error, 'WebChannel: connect %s failed!' % url) |
There was a problem hiding this comment.
change the error message like below. It's more precise, and guide user to fix it.
WebChannel: connect to %s timeout! Please make sure NNIManagerIP configured correclty, and accessable.
squirrelsc
reviewed
Jul 22, 2020
| try: | ||
| connect = asyncio.wait_for(websockets.connect(url), self.timeout) | ||
| self._event_loop = asyncio.get_event_loop() | ||
| client = self._event_loop.run_until_complete(connect) |
There was a problem hiding this comment.
Is it possible to hang at this line in some cases? Is a timeout needed for event loop?
There was a problem hiding this comment.
This self._event_loop.run_until_complete(connect) is for connect method, and connect has already handled timeout.
squirrelsc
approved these changes
Jul 23, 2020
chicm-ms
reviewed
Jul 24, 2020
tools/nni_trial_tool/web_channel.py
Outdated
| self.client = client | ||
| nni_log(LogType.Info, 'WebChannel: connected with info %s' % url) | ||
| except asyncio.TimeoutError: | ||
| nni_log(LogType.Error, 'connect to %s timeout! Please make sure NNIManagerIP configured correclty, and accessable.' % url) |
chicm-ms
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.