[fix issue#4015] webui prompts error message if user set maxExperimen…

…tDuration < execDuration (#4164)
microsoft · Sep 15, 2021 · 0ad73ef · 0ad73ef
1 parent 8875fa7
commit 0ad73ef
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/ts/webui/src/components/overview/count/EditExperimentParam.tsx b/ts/webui/src/components/overview/count/EditExperimentParam.tsx
@@ -2,6 +2,7 @@ import React, { useState, useCallback, useContext } from 'react';
 import axios from 'axios';
 import { Dropdown } from '@fluentui/react';
 import { EXPERIMENT } from '../../../static/datamodel';
+import { toSeconds } from '../../../static/experimentConfig';
 import { AppContext } from '../../../App';
 import { EditExpeParamContext } from './context';
 import { durationUnit } from '../overviewConst';
@@ -63,20 +64,32 @@ export const EditExperimentParam = (): any => {
         }
     }
 
+    function promptErrorMessage(mess: string, type: string, value: string): void {
+        showMessageInfo(mess, type);
+        setEditValInput(value);
+    }
+
     async function confirmEdit(): Promise<void> {
         const isMaxDuration = title === 'Max duration';
         const newProfile = Object.assign({}, EXPERIMENT.profile);
         let beforeParam = '';
         if (isMaxDuration) {
             if (!editInputVal.match(/^\d+(?=\.{0,1}\d+$|$)/)) {
-                showMessageInfo('Please enter a number!', 'error');
-                setEditValInput(defaultVal);
+                promptErrorMessage('Please enter a number!', 'error', defaultVal);
+                return;
+            }
+            if (toSeconds(`${editInputVal}${unit}`) < EXPERIMENT.profile.execDuration) {
+                // maxDuration should > current run time(execDuration)
+                promptErrorMessage(
+                    'Please input a valid value. (Current duration is more than the number you input.)',
+                    'error',
+                    defaultVal
+                );
                 return;
             }
         } else {
             if (!editInputVal.match(/^[1-9]\d*$/)) {
-                showMessageInfo('Please enter a positive integer!', 'error');
-                setEditValInput(defaultVal);
+                promptErrorMessage('Please enter a positive integer!', 'error', defaultVal);
                 return;
             }
         }