Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positional Embeddings should be MuReadout parameters ? #48

Open
codedecde opened this issue May 31, 2023 · 2 comments
Open

Positional Embeddings should be MuReadout parameters ? #48

codedecde opened this issue May 31, 2023 · 2 comments

Comments

@codedecde
Copy link

Duplicate of question asked on the mutransformers repository (link)

Hi !
I was wondering if (learned) positional embeddings should be MuReadout layers, since they map to a finite dimensional space. Specifically

https://github.com/microsoft/mutransformers/blob/480287ce7b18a07a3432e8f2fbc0f0e5b71e2599/mutransformers/models/bert/modeling_bert.py#L174

self.position_embeddings = nn.Embedding(config.max_position_embeddings, config.hidden_size)

In addition to that, did you try using muP for sparse MoE models ? Am curious about any findings for those. Specifically, I was wondering if the routing gate (hdim, num_experts) would also be a MuReadout layer (if we don't scale the number of experts).

Would be grateful for any advice :)

Thank you !

@thegregyang
Copy link
Contributor

thegregyang commented Jun 1, 2023 via email

@codedecde
Copy link
Author

Thank you !
I meant that the sequence length aspect is finite (similar to vocab size) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants