Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QemuRunner.py: Allow a user specified QEMU path #762

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

makubacki
Copy link
Member

Description

On Linux, I build QEMU images with various features enabled. To more
easily enable users to use a custom QEMU image, this change
introduces a new variable QEMU_PATH that will override the default
executable used from the system path if provided.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

  • Built packages with QEMU_PATH present and not present.

Integration Instructions

N/A - Instructions for usage are in Platforms/Docs/Common/building.md

On Linux, I build QEMU images with various features enabled. To more
easily enable users to use a custom QEMU image, this change
introduces a new variable `QEMU_PATH` that will override the default
executable used from the system path if provided.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki added the semver:patch Pull requests that should increment the release patch version label Nov 6, 2023
@makubacki makubacki self-assigned this Nov 6, 2023
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Nov 6, 2023
@makubacki makubacki merged commit ddecf2d into microsoft:main Nov 6, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code semver:patch Pull requests that should increment the release patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants