QemuQ35Pkg.dsc: Apply XenHypercallLib to valid archs #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Javagedes
approved these changes
Sep 23, 2024
kuqin12
approved these changes
Sep 23, 2024
The XenHypercallLib instance in QemuQ35Pkg has the following
LIBRARY_CLASS value in its [DEFINES] section:
[Defines.IA32, Defines.X64]
LIBRARY_CLASS = XenHypercallLib|...
[Defines.ARM, Defines.AARCH64]
LIBRARY_CLASS = XenHypercallLib
However, the library instance is specified in QemuQ35Pkg.dsc
against the "Common" architecture as it is placed in the
[LibraryClasses] section.
This raises the following warning during build:
INFO - QemuQ35Pkg.dsc(...): warning:
Platforms\QemuQ35Pkg\Library\XenHypercallLib\XenHypercallLib.inf
does not support LIBRARY_CLASS XenHypercallLib
This is printed from the `_ValidateLibraryClass()` function in
`BaseTools/Source/Python/Workspace/DscBuildData.py` because the
library class is bound by architecture in the INF file so it does
*not* support the "Common" architecture.
This change maps the library instance to the XenHypercallLib class
per the defined architectures (`IA32` and `X64`) in QemuQ35Pkg.dsc.
Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
q35_xenhypercall_lib_dsc_change
branch
from
76f3601
to
c3d2f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The XenHypercallLib instance in QemuQ35Pkg has the following LIBRARY_CLASS value in its [DEFINES] section:
However, the library instance is specified in QemuQ35Pkg.dsc against the "Common" architecture as it is placed in the
[LibraryClasses]section.This raises the following warning during build:
This is printed from the
_ValidateLibraryClass()function inBaseTools/Source/Python/Workspace/DscBuildData.pybecause the library class is bound by architecture in the INF file so it does not support the "Common" architecture.This change maps the library instance to the XenHypercallLib class per the defined architectures (
IA32andX64) in QemuQ35Pkg.dsc.How This Was Tested
QemuQ35Pkgbefore and after the changeIntegration Instructions