Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OemPkg/HelloUefi - CI fixes #117

Merged
merged 4 commits into from
Jul 8, 2023

Conversation

Flickdm
Copy link
Member

@Flickdm Flickdm commented Jul 7, 2023

Description

This is the simplest possible UEFI application, it differs from HelloWorld in that it drops dependencies on libraries, and eliminates the PCD logic, this application ideal purpose is to be used to test secure boot certificates as it's attack surface is minimal.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Built with stuart_ci_build and wsl

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jul 7, 2023
@Flickdm Flickdm requested review from os-d and Javagedes July 7, 2023 21:26
Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add the uncrustify fixes and Michael's comments from the first PR that weren't merged? As well as updating the PR title and description :).

@makubacki makubacki force-pushed the feature/hello_uefi branch from c6a9af5 to 5765954 Compare July 7, 2023 22:30
@makubacki
Copy link
Member

makubacki commented Jul 7, 2023

Had to run unix2dos in a filter-branch but the line endings are good now.

I removed some boilerplate template text from the PR description and it is bare now. Can you update with the description for these changes?

Also, please include this request from the previous PR:

#116 (comment)

I think the comment that this is the simplest UEFI application possible in the file comments is sufficient, but in the PR Description it would be nice to add more detailed context about why this was created given https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Application/HelloWorld/HelloWorld.inf exists.

Eliminating PCD logic, dropping library dependencies, etc...

@makubacki makubacki changed the title updating targets OemPkg/HelloUefi - CI fixes Jul 8, 2023
@Flickdm Flickdm enabled auto-merge (squash) July 8, 2023 00:18
@Flickdm Flickdm merged commit 54d70cd into microsoft:release/202302 Jul 8, 2023
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Jul 15, 2023
Introduces 7 new commits in [Common/MU_OEM_SAMPLE](https://github.com/microsoft/mu_oem_sample.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/747440cedf1eef6180c00cb83d66736ef3aa45d6">747440</a> pip: update edk2-pytool-extensions requirement from ~=0.23.6 to ~=0.23.8 (<a href="https://github.com/microsoft/mu_oem_sample/pull/114">#114</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/b27b72aba283ab8a9a64846530775f535a36e31a">b27b72</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_oem_sample/pull/115">#115</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/563c877f0750b52f5b05327fae6f48fe60b28083">563c87</a> HelloUefi init (<a href="https://github.com/microsoft/mu_oem_sample/pull/116">#116</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/54d70cdf064947df64890672c2da73413c46fbe3">54d70c</a> OemPkg/HelloUefi - CI fixes (<a href="https://github.com/microsoft/mu_oem_sample/pull/117">#117</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/bcd2bdcb4c2f66c29b1e0025b739b0383ee346c6">bcd2bd</a> adding stack cookie support (<a href="https://github.com/microsoft/mu_oem_sample/pull/119">#119</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/d479c883e15187f09138bc51bd604f7af250e0d8">d479c8</a> HelloUefi: Add 30 second stall (<a href="https://github.com/microsoft/mu_oem_sample/pull/120">#120</a>)</li>
<li><a href="https://github.com/microsoft/mu_oem_sample/commit/746b4426487c9f254657e0d1ee461e5e819ee81b">746b44</a> OemPkg: Fix build (<a href="https://github.com/microsoft/mu_oem_sample/pull/121">#121</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants