-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RustEnvironmentCheck: Bugfix embedded quotes #749
Merged
Javagedes
merged 1 commit into
microsoft:release/202311
from
Javagedes:RustEnvironmentCheck-bugfix
Feb 22, 2024
Merged
RustEnvironmentCheck: Bugfix embedded quotes #749
Javagedes
merged 1 commit into
microsoft:release/202311
from
Javagedes:RustEnvironmentCheck-bugfix
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces embedded double quotes with single quotes in the RustEnvironmentCheck plugin as embedded double quotes support when working with f-strings was only added in python 3.12, and this project should support python 3.10, 3.11, and 3.12.
github-actions
bot
added
language:python
Pull requests that update Python code
impact:non-functional
Does not have a functional impact
labels
Feb 22, 2024
makubacki
approved these changes
Feb 22, 2024
Flickdm
approved these changes
Feb 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #749 +/- ##
===============================================
Coverage 1.24% 1.24%
===============================================
Files 1301 1301
Lines 332064 332064
Branches 5127 5127
===============================================
Hits 4126 4126
Misses 327891 327891
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Feb 22, 2024
Introduces 5 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/973f63be0017d01024e6b4a950db4e6e85d8faea">973f63</a> RustEnvironmentCheck: Check Version if specified (<a href="https://github.com/microsoft/mu_basecore/pull/737">#737</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e3a139fa066c52271ac490a19b9d5bad6f9c7a18">e3a139</a> remove edk2-basetools (<a href="https://github.com/microsoft/mu_basecore/pull/732">#732</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/35d06ff4ddaa68a0e62cfb64b5d1225930e1eb43">35d06f</a> BaseTools/RustEnvironmentCheck: Allow no tools in toolchain file (<a href="https://github.com/microsoft/mu_basecore/pull/746">#746</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/2c504985e1c9fc44a002f7d2c1a44b31aa5a87d5">2c5049</a> Edk2ToolsBuild: override basetoolsbin_ext_dep (<a href="https://github.com/microsoft/mu_basecore/pull/745">#745</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/d5379bdd63dc290d209b43746e0ab83108661ce4">d5379b</a> RustEnvironmentCheck: Bugfix embedded quotes (<a href="https://github.com/microsoft/mu_basecore/pull/749">#749</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Javagedes
referenced
this pull request
in microsoft/mu_tiano_platforms
Feb 22, 2024
Bumps MU_BASECORE from `2023110001.0.2` to `2023110001.1.0` Introduces 5 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/973f63be0017d01024e6b4a950db4e6e85d8faea">973f63</a> RustEnvironmentCheck: Check Version if specified (<a href="https://github.com/microsoft/mu_basecore/pull/737">#737</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e3a139fa066c52271ac490a19b9d5bad6f9c7a18">e3a139</a> remove edk2-basetools (<a href="https://github.com/microsoft/mu_basecore/pull/732">#732</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/35d06ff4ddaa68a0e62cfb64b5d1225930e1eb43">35d06f</a> BaseTools/RustEnvironmentCheck: Allow no tools in toolchain file (<a href="https://github.com/microsoft/mu_basecore/pull/746">#746</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/2c504985e1c9fc44a002f7d2c1a44b31aa5a87d5">2c5049</a> Edk2ToolsBuild: override basetoolsbin_ext_dep (<a href="https://github.com/microsoft/mu_basecore/pull/745">#745</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/d5379bdd63dc290d209b43746e0ab83108661ce4">d5379b</a> RustEnvironmentCheck: Bugfix embedded quotes (<a href="https://github.com/microsoft/mu_basecore/pull/749">#749</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
language:python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces embedded double quotes with single quotes in the RustEnvironmentCheck plugin as embedded double quotes support when working with f-strings was only added in python 3.12, and this project should support python 3.10, 3.11, and 3.12.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Verified the plugin works on 3.10, 3.11, and 3.12
Integration Instructions
N/A