Skip to content

Fix | Security Issue specified by sonarqube #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheenamalhotra merged 6 commits into from
Jan 11, 2019
Merged

Fix | Security Issue specified by sonarqube #928

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64732b4
Fix | Security Issue specified by sonarqube
rene-ye Jan 9, 2019
7e86bf3
Fix | Typo in readme
rene-ye Jan 10, 2019
055898c
Fix | Code smell fixes part 1
rene-ye Jan 10, 2019
90ddea5
Fix | Code smells part 2
rene-ye Jan 10, 2019
7a486ad
Fix implementation for getBytes()
cheenamalhotra Jan 11, 2019
f3246bf
Fix naming conventions + remove unwanted code
cheenamalhotra Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ Projects that require either of the two features need to explicitly declare the

<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>zure-keyvault-webkey</artifactId>
<artifactId>azure-keyvault-webkey</artifactId>
<version>1.2.0</version>
</dependency>
```
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ InputStream getValue() throws SQLServerException {
TransformerFactory factory;
try {
factory = TransformerFactory.newInstance();
factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
factory.newTransformer().transform(new DOMSource(docValue), new StreamResult(strm));
} catch (javax.xml.transform.TransformerException e) {
MessageFormat form = new MessageFormat(SQLServerException.getErrString("R_noParserSupport"));
Expand Down Expand Up @@ -454,6 +455,7 @@ private SAXResult getSAXResult() throws SQLException {
TransformerHandler handler = null;
try {
SAXTransformerFactory stf = (SAXTransformerFactory) TransformerFactory.newInstance();
stf.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
handler = stf.newTransformerHandler();
} catch (TransformerConfigurationException e) {
MessageFormat form = new MessageFormat(SQLServerException.getErrString("R_noParserSupport"));
Expand Down