Push dev to Master post release v7.1.1#810
Merged
cheenamalhotra merged 9 commits intomasterfrom Sep 28, 2018
Merged
Conversation
* Update driver patch for next release. * Modify test to always check for equal Driver version and Build versions.
1st part of Junit test cleanup: - use try-with-resources on closeables and fix leaks - get rid shared variables between tests - move testframework/util/Util.java to TestUtil (part of work get rid of testframework)
1. Removing the catch block, because the driver should not blindly send attention packets. To cancel a query, attention packets should only be sent if the client has already sent a request, which has the last packet with EOM bit (0x01) set in status. If a complete request has not been sent to the server, the driver MUST send the next packet with both ignore bit (0x02) and EOM bit (0x01) set in the status to cancel the request (2.2.1.7 of TDS Technical Documentation). This is already properly handled in IOBuffer.execute(), which is the only method that calls doInsertBulk(). 2. Adding this.tdsMessageType == TDS.PKT_BULK, because prior to TDS.PKT_BULK, the driver has already sent INSERT BULK SQL statement to the server, which in case of an exception needs to be cancelled too.
…ECIMAL/NUMERIC types (#796)
…se the stream for Clobs/NClobs (#799) Addresses #788. Also addressed an issue where varchar(max)/Clob objects were always being encoded to UTF-16LE instead of using the Collation specified in the Clob object. List of Changes (the following applies to NClob as well): 1. calling Clob.length() no longer attempts to load the stream into a string. This fixes a null pointer issue as well as length() closing user streams. 2. added streaming capabilities for Clob.getAsciiStream(). NClobs will always have a non-streaming implementation for getAsciiStream(). 3. Clobs no longer default to UTF-16LE. Clobs now respect the collation from the SQL Server. NClobs remain unchanged, will always be UTF-16LE encoding.
…ments in SQLServerParameterMetadata (#780)
rene-ye
approved these changes
Sep 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
============================================
+ Coverage 48.23% 48.72% +0.48%
- Complexity 2788 2817 +29
============================================
Files 116 116
Lines 27862 27878 +16
Branches 4641 4651 +10
============================================
+ Hits 13440 13583 +143
+ Misses 12201 12162 -39
+ Partials 2221 2133 -88
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.