Skip to content

Fix for the issue when using setMaxRows() with SHOWPLAN ON #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulvii merged 5 commits into from
Apr 5, 2018
Merged

Fix for the issue when using setMaxRows() with SHOWPLAN ON #666

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01ba7b2
Dont throw exception for colmetadata token
ulvii Mar 23, 2018
d7e9ddd
Adding a comment
ulvii Mar 26, 2018
91f3caa
Update comment
ulvii Mar 26, 2018
83d9e23
Adding a warning message
ulvii Mar 28, 2018
25da122
remove ignoreLengthPrefixedToken
ulvii Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/com/microsoft/sqlserver/jdbc/tdsparser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ class TDSTokenHandler {

private StreamError databaseError;

/** TDS protocol diagnostics logger */
private static Logger logger = Logger.getLogger("com.microsoft.sqlserver.jdbc.internals.TDS.TOKEN");

final StreamError getDatabaseError() {
return databaseError;
}
Expand Down Expand Up @@ -227,7 +230,10 @@ boolean onOrder(TDSReader tdsReader) throws SQLServerException {
}

boolean onColMetaData(TDSReader tdsReader) throws SQLServerException {
TDSParser.throwUnexpectedTokenException(tdsReader, logContext);
//SHOWPLAN might be ON, instead of throwing an exception, ignore the column meta data
if (logger.isLoggable(Level.SEVERE))
logger.severe(tdsReader.toString() + ": " + logContext + ": Encountered "
+ TDS.getTokenName(tdsReader.peekTokenType()) + ". SHOWPLAN is ON, ignoring.");
return false;
}

Expand Down