Skip to content

use matrix to test against both SQL Server 2016 and 2008 #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyushawn merged 6 commits into from
Dec 1, 2017
Merged

use matrix to test against both SQL Server 2016 and 2008 #428

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6277eb
use matrix to test against both SQL Server 2016 and 2008
xiangyushawn Aug 2, 2017
0587b66
miss a `;`
xiangyushawn Aug 2, 2017
e650225
use matrix and init to start services
xiangyushawn Aug 2, 2017
f4c7604
simplify appveyor configuration
xiangyushawn Aug 2, 2017
fddcb30
fix 2 test failures against sql server 2008
xiangyushawn Aug 9, 2017
6607087
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into te…
xiangyushawn Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
version: '{build}'

environment:
mssql_jdbc_test_connection_properties: jdbc:sqlserver://localhost:1433;instanceName=SQL2016;databaseName=master;username=sa;password=Password12!;
JAVA_HOME: C:\Program Files\Java\jdk1.8.0

matrix:
- JAVA_HOME: C:\Program Files\Java\jdk1.8.0
- mssql_jdbc_test_connection_properties: jdbc:sqlserver://localhost:1433;instanceName=SQL2008R2SP2;databaseName=master;username=sa;password=Password12!;

- mssql_jdbc_test_connection_properties: jdbc:sqlserver://localhost:1433;instanceName=SQL2016;databaseName=master;username=sa;password=Password12!;

services:
- mssql2008r2sp2

@nsidhaye nsidhaye Aug 2, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work?
I guess you should add services also in matrix.

matrix:
  - SQL: mssql2008r2sp2
   mssql_jdbc_test_connection_properties: jdbc:sqlserver://localhost:1433;instanceName=SQL2008R2SP2;databaseName=master;username=sa;password=Password12!;
  - SQL: mssql2016
   mssql_jdbc_test_connection_properties: jdbc:sqlserver://localhost:1433;instanceName=SQL2016;databaseName=master;username=sa;password=Password12!;

I did not check this but definitely you want matrix of services too.

Ref: https://stackoverflow.com/questions/42690548/multiple-combinations-of-python-and-sql-server-on-appveyor

Also please note that all MS SQL servers use the same default port 1433. Therefore please start and stop them sequentially to avoid port conflicts. To allow all SQL Server instances to be started simultaneously, please run this script at init stage.

Ref: https://www.appveyor.com/docs/services-databases/

@xiangyushawn xiangyushawn Aug 2, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nsidhaye Hope you are doing well! from my investigation, matrix does not support services. Before I create this PR, I tested it in my personal fork and it worked this way. Thank you for sharing the link, I definitely will try it! If it works I will update my PR. Thank you :)

@xiangyushawn xiangyushawn Aug 2, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @nsidhaye for sharing the link! I didn't find this link when I was doing investigation. I really love the idea to specify variables in matrix and then use CMD to start services! I updated my PR. Thank you for knowledge sharing!

- mssql2016

install:
- ps: Write-Host 'Installing JCE with powershell'
- ps: cd AppVeyorJCE
Expand Down