Refactor getColumns() to use sp_columns_170 with fallback to sp_columns_100 by muskan124947 · Pull Request #2883 · microsoft/mssql-jdbc

muskan124947 · 2026-01-23T12:43:54Z

Desciption

With SQL Server 2025, new data types and features such as VECTOR and enhanced JSON support have been introduced.
The legacy metadata stored procedure sp_columns_100 does not return correct or complete data type information for these newer features.

SQL Server 2025 exposes updated metadata via sp_columns_170, which aligns column metadata with newer engine capabilities.
This change updates DatabaseMetaData.getColumns() to prefer sp_columns_170 when available, while safely falling back to sp_columns_100 for backward compatibility.

The implementation is defensive and forward-compatible, ensuring no regressions on older SQL Server versions or Azure environments while allowing JDBC to automatically benefit from future metadata improvements.

Issues

Changes

Refactored SQLServerDatabaseMetaData.getColumns into non-Azure and Azure DW helper methods, added shared helpers to parameterize sp_columns calls and apply filters, and updated logging.
Modified the vector metadata test to call DatabaseMetaData.getColumns more generically and added diagnostic output around returned column metadata.

Testing

Unit/integration tests updated where needed (spatial + vector metadata expectations)
Verified metadata returned by DatabaseMetaData.getColumns() includes newer SQL Server 2025 types when sp_columns_170 is available.
Backward compatibility maintained via fallback to sp_columns_100 when sp_columns_170 is not available

Copilot

Pull request overview

This PR refactors DatabaseMetaData.getColumns to support newer SQL Server metadata stored procedures and updates Microsoft-specific SQL type codes and tests (including spatial and vector types) to align with the new values.

Changes:

Refactored SQLServerDatabaseMetaData.getColumns into non-Azure and Azure DW helper methods, added shared helpers to parameterize sp_columns calls and apply filters, and updated logging.
Updated microsoft.sql.Types constants for several SQL Server–specific types (DATETIME, SMALLDATETIME, GUID, SQL_VARIANT, GEOMETRY, GEOGRAPHY, VECTOR, JSON) and adjusted spatial metadata tests to expect the new codes.
Modified the vector metadata test to call DatabaseMetaData.getColumns more generically and added diagnostic output around returned column metadata.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java	Refactors `getColumns` into separate non-Azure/Azure DW paths, introduces helpers for building and filtering the result sets, and intends to support `sp_columns_170` with fallback to `sp_columns_100`.
src/main/java/microsoft/sql/Types.java	Adjusts Microsoft-specific SQL type code constants for datetime, GUID, SQL_VARIANT, spatial, vector, and JSON types.
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/SQLServerSpatialDatatypeTest.java	Updates geometry/geography metadata tests to assert the new vendor type codes from `ParameterMetaData` and `ResultSetMetaData`.
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/VectorTest.java	Changes the `getColumns` call to use a wildcard column pattern and logs all returned metadata for debugging of the VECTOR type mapping.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-01-23T14:06:45Z

Codecov Report

❌ Patch coverage is 66.66667% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.23%. Comparing base (dfdadee) to head (a8f53ce).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java	66.66%	45 Missing and 11 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2883      +/-   ##
============================================
+ Coverage     58.87%   59.23%   +0.36%     
- Complexity     4778     4807      +29     
============================================
  Files           151      151              
  Lines         34748    34781      +33     
  Branches       5827     5829       +2     
============================================
+ Hits          20457    20603     +146     
+ Misses        11502    11390     -112     
+ Partials       2789     2788       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…o run on sql server instance only

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Update getColumns() to use sp_columns_170 and fix data type values

71bbc5d

muskan124947 self-assigned this Jan 23, 2026

Fix geometry and geography related test failures

50e4ca8

muskan124947 requested a review from Copilot January 23, 2026 13:30

Copilot started reviewing on behalf of muskan124947 January 23, 2026 13:30 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java Outdated

Comment thread src/test/java/com/microsoft/sqlserver/jdbc/datatypes/VectorTest.java

Add sp_columns_170

9ce7e55

Copilot AI reviewed Jan 23, 2026

View reviewed changes

muskan124947 requested a review from Copilot January 23, 2026 14:24

Copilot started reviewing on behalf of muskan124947 January 23, 2026 14:25 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java Outdated

Refactored fix and added test cases

6501d28

muskan124947 requested a review from Copilot January 23, 2026 18:42

Copilot started reviewing on behalf of muskan124947 January 23, 2026 18:42 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Comment thread src/test/java/com/microsoft/sqlserver/jdbc/datatypes/VectorTest.java Outdated

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java Outdated

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java Outdated

muskan124947 added 2 commits January 24, 2026 00:36

Fixed test case

d410352

Cleanup

7922af0

muskan124947 requested a review from Copilot January 23, 2026 19:16

Copilot started reviewing on behalf of muskan124947 January 23, 2026 19:17 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Comment thread src/main/java/microsoft/sql/Types.java Outdated

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java

muskan124947 changed the title ~~[WIP] Fix getColumns() to use sp_columns_170 and data types values~~ Refactor getColumns() to use sp_columns_170 and align data types values Jan 27, 2026

github-project-automation bot added this to MSSQL JDBC Jan 27, 2026

github-project-automation bot moved this to In progress in MSSQL JDBC Jan 27, 2026

muskan124947 requested review from Ananya2, divang and machavan January 27, 2026 04:02

muskan124947 added the Under Review Used for pull requests under review label Jan 27, 2026

Fixed fallback comment and enabled vector test using sp_columns_170 t…

d3c8008

…o run on sql server instance only

muskan124947 requested a review from Copilot January 27, 2026 09:37

Add vectorJsonTest annotation to testCheckMetaData

0ff8a15

muskan124947 requested a review from Copilot January 28, 2026 10:29

Copilot started reviewing on behalf of muskan124947 January 28, 2026 10:30 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java

muskan124947 added 2 commits January 28, 2026 16:13

Add import for vectorJsonTest in ParameterMetaDataTest

4b1def0

Reverted microsoft.sql.Types values and updated test scenarios

ce8ba06

muskan124947 requested a review from Copilot January 29, 2026 03:58

Copilot started reviewing on behalf of muskan124947 January 29, 2026 03:58 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Comment thread src/test/java/com/microsoft/sqlserver/jdbc/datatypes/VectorTest.java

Comment thread src/test/java/com/microsoft/sqlserver/jdbc/datatypes/VectorTest.java

Updated test tag

36fcb75

muskan124947 requested a review from David-Engel January 29, 2026 05:13

muskan124947 changed the title ~~Refactor getColumns() to use sp_columns_170 and align data types values~~ Refactor getColumns() to use sp_columns_170 with fallback to sp_columns_100 Jan 29, 2026

divang reviewed Jan 29, 2026

View reviewed changes

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java Outdated

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java Outdated

Addressed comment

8eb04f3

muskan124947 requested a review from Copilot January 29, 2026 09:43

Copilot started reviewing on behalf of muskan124947 January 29, 2026 09:44 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Comment thread src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataTest.java

Comment thread src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java

Add vectorJsonTest annotation to testCheckMetaData

a8f53ce

kirkhansen mentioned this pull request Feb 2, 2026

Add native JSON type support to SQL Server connector trinodb/trino#28082

Open

divang approved these changes Feb 3, 2026

View reviewed changes

machavan approved these changes Feb 3, 2026

View reviewed changes

muskan124947 merged commit 19d385f into main Feb 3, 2026
19 checks passed

github-project-automation bot moved this from In progress to Closed/Merged PRs in MSSQL JDBC Feb 3, 2026

This was referenced Feb 3, 2026

JDBC driver metadata does list vector columns #2862

Closed

Columns of the new MSSQL 2025 data type JSON are omitted during table schema discovery #2878

Closed

This was linked to issues Feb 3, 2026

Columns of the new MSSQL 2025 data type JSON are omitted during table schema discovery #2878

Closed

JDBC driver metadata does list vector columns #2862

Closed

muskan124947 removed the Under Review Used for pull requests under review label Feb 3, 2026

kirkhansen mentioned this pull request Feb 3, 2026

Add native JSON type support for SQL Server 2025 trinodb/trino#28101

Open

jpechane mentioned this pull request Feb 13, 2026

Support for vector datatype in SQL Server [DBZ-8481] debezium/dbz#1208

Open

Conversation

muskan124947 commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Desciption

Issues

Changes

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

muskan124947 commented Jan 23, 2026 •

edited

Loading

codecov bot commented Jan 23, 2026 •

edited

Loading