Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced timeouts for MSAL calls. #2562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

machavan
Copy link
Contributor

Description:

Calls to MSAL authentication library done from the Java driver code use future.get(), potentially leading to hangs in case the library does not receive timely response from the server. All these calls done as part of getFedAuthToken need to have timeouts imposed. The timeout period is calculated based on remaining time wrt login timeout, and passed to future.get(, ) calls with this fix.

Tests:

  • Existing tests pass
  • New tests to be added

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 51.16%. Comparing base (6829848) to head (db6e39d).

Files with missing lines Patch % Lines
...microsoft/sqlserver/jdbc/SQLServerMSAL4JUtils.java 0.00% 14 Missing ⚠️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 25.00% 3 Missing ⚠️
...osoft/sqlserver/jdbc/SQLServerSecurityUtility.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2562      +/-   ##
============================================
+ Coverage     51.03%   51.16%   +0.13%     
- Complexity     3919     3954      +35     
============================================
  Files           147      147              
  Lines         33456    33466      +10     
  Branches       5604     5604              
============================================
+ Hits          17074    17123      +49     
- Misses        13971    13974       +3     
+ Partials       2411     2369      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant