Cleanup writeSQLVariant (removed unused parameter, remove duplicate code, spelling fixes)#2411
Merged
Jeffery-Wasty merged 5 commits intomainfrom May 9, 2024
Merged
Cleanup writeSQLVariant (removed unused parameter, remove duplicate code, spelling fixes)#2411Jeffery-Wasty merged 5 commits intomainfrom
writeSQLVariant (removed unused parameter, remove duplicate code, spelling fixes)#2411Jeffery-Wasty merged 5 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
============================================
+ Coverage 50.18% 50.25% +0.07%
- Complexity 3838 3868 +30
============================================
Files 145 145
Lines 33360 33355 -5
Branches 5654 5654
============================================
+ Hits 16742 16763 +21
- Misses 14228 14229 +1
+ Partials 2390 2363 -27 ☔ View full report in Codecov by Sentry. |
barryw-mssql
previously approved these changes
May 8, 2024
This reverts commit 583679d.
writeSQLVariantwriteSQLVariant (removed unused parameter, remove duplicate code, spelling fixes)
lilgreenbird
approved these changes
May 8, 2024
barryw-mssql
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused
bulkScaleparameter inwriteSQLVariant. Also some spelling and other small changes to this method since we have the chance to make changes.Original issue was created to address missing cleanup from #747.