Fixed race condition connecting to the wrong SQLServer host in configurable IPv6#1965
Merged
tkyc merged 6 commits intomicrosoft:mainfrom Dec 14, 2022
Merged
Fixed race condition connecting to the wrong SQLServer host in configurable IPv6#1965tkyc merged 6 commits intomicrosoft:mainfrom
tkyc merged 6 commits intomicrosoft:mainfrom
Conversation
Release | Merge dev to master for 9.1.1-preview release
Merge dev to master for 9.2.0 release (microsoft#1506)
# Conflicts: # CHANGELOG.md # README.md # azure-pipelines.yml # build.gradle # mssql-jdbc_auth_LICENSE # pom.xml # src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java # src/main/java/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java # src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java # src/main/java/com/microsoft/sqlserver/jdbc/SQLServerMSAL4JUtils.java # src/samples/adaptive/pom.xml # src/samples/alwaysencrypted/pom.xml # src/samples/azureactivedirectoryauthentication/pom.xml # src/samples/connections/pom.xml # src/samples/constrained/pom.xml # src/samples/dataclassification/pom.xml # src/samples/datatypes/pom.xml # src/samples/resultsets/pom.xml # src/samples/sparse/pom.xml # src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java # src/test/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetaDataTest.java # src/test/java/com/microsoft/sqlserver/jdbc/fedauth/ErrorMessageTest.java
…d each time anyway.
Contributor
|
thanks for the contribution @mmimica, could you please add a test for this? |
Contributor
Author
|
I can't. A unit test would require a larger refactoring as host lookup code would need to be stubbed, and two servers in the test environment. |
lilgreenbird
approved these changes
Dec 14, 2022
Jeffery-Wasty
approved these changes
Dec 14, 2022
tkyc
approved these changes
Dec 14, 2022
tkyc
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Merge dev to master for 9.2.0 release (#1506) Merge dev to master for 9.2.0 release (#1506) * fix merge * Fix #1964 by not having a static field at all. It was cleared each time anyway. * refactor a bit Co-authored-by: ulvii <v-ulibra@microsoft.com> Co-authored-by: Peter Bae <v-hyba@microsoft.com> Co-authored-by: Milan Mimica <milan.mimica@infobip.com>
tkyc
pushed a commit
that referenced
this pull request
Dec 28, 2022
* Merge dev to master for 9.2.0 release (#1506) Merge dev to master for 9.2.0 release (#1506) * fix merge * Fix #1964 by not having a static field at all. It was cleared each time anyway. * refactor a bit Co-authored-by: ulvii <v-ulibra@microsoft.com> Co-authored-by: Peter Bae <v-hyba@microsoft.com> Co-authored-by: Milan Mimica <milan.mimica@infobip.com>
tkyc
pushed a commit
that referenced
this pull request
Dec 29, 2022
* Merge dev to master for 9.2.0 release (#1506) Merge dev to master for 9.2.0 release (#1506) * fix merge * Fix #1964 by not having a static field at all. It was cleared each time anyway. * refactor a bit Co-authored-by: ulvii <v-ulibra@microsoft.com> Co-authored-by: Peter Bae <v-hyba@microsoft.com> Co-authored-by: Milan Mimica <milan.mimica@infobip.com>
tkyc
added a commit
that referenced
this pull request
Dec 29, 2022
* Merge dev to master for 9.2.0 release (#1506) Merge dev to master for 9.2.0 release (#1506) * fix merge * Fix #1964 by not having a static field at all. It was cleared each time anyway. * refactor a bit Co-authored-by: ulvii <v-ulibra@microsoft.com> Co-authored-by: Peter Bae <v-hyba@microsoft.com> Co-authored-by: Milan Mimica <milan.mimica@infobip.com> Co-authored-by: Milan Mimica <milan.mimica@gmail.com> Co-authored-by: ulvii <v-ulibra@microsoft.com> Co-authored-by: Peter Bae <v-hyba@microsoft.com> Co-authored-by: Milan Mimica <milan.mimica@infobip.com>
lilgreenbird
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1964 by not having a static field at all. It was cleared each time anyway.