Fix | Changes after 9.2.0 static analysis#1498
Merged
peterbae merged 9 commits intomicrosoft:devfrom Jan 25, 2021
Merged
Conversation
…ore comparing to avoid intermittent insert/retrieve errors
| */ | ||
| @Immutable | ||
| class KeyVaultTokenCredential implements TokenCredential { | ||
| private static final String NULL_VALUE = "R_NullValue"; |
Contributor
There was a problem hiding this comment.
if you do this why not define this to be the error string?
i.e. private static final String NULL_VALUE = SQLServerException.getErrString("R_NullValue");
peterbae
approved these changes
Jan 25, 2021
lilgreenbird
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes static code analysis issues since last release.