Skip to content

Conversation

@ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Feb 14, 2023

Description

On Ubuntu20.04
prepare-machine.ps1 only initialize one of submodules/openssl, but build.ps1 use openssl3
#3426

Testing

build succeeded by newly cloned repo

Documentation

N/A

@ami-GS ami-GS requested a review from a team as a code owner February 14, 2023 18:00
wfurt
wfurt previously approved these changes Feb 14, 2023
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I like sharing the logic.

nibanks
nibanks previously approved these changes Feb 14, 2023
@ami-GS ami-GS dismissed stale reviews from nibanks and wfurt via a2e2c31 February 14, 2023 19:52
@ami-GS ami-GS merged commit 335d3e9 into main Feb 15, 2023
@ami-GS ami-GS deleted the dev/daiki/linux_tls_build_fix branch February 15, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants