-
Notifications
You must be signed in to change notification settings - Fork 611
Add support for OpenSSL 3 as alternative TLS #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run ci |
|
Pull request contains merge conflicts. |
|
My experience with this change is not very good, so I've picked some interesting print lines from the build: Note the Picks wrongly OpenSSL 1.1 submodule (or is wrongly using system OpenSSL 3.0.7) Regardless of the previous mismatch, successfully builds libmsquic. After installation of this frankenlib in the system, System.Net.Quic tests crash with:
|
|
The selection is not automatic @ManickaP - at least not with this change. You have to pass There should be guard for the mismatch. I can check why it is not working. |
That doesn't work.
I hope it's planned though.
Works with |
builds up on #2103
Contributes to #2039
Unlike the original PR this does not tries to switch OpenSSL but it adds OpenSSL as alternative TLS.
By default it adds additional OpenSSL drop but it can can be controlled during checkout (instead of default recursive)
It adds openssl3 submodule so MsQuic can be either build with OpenSSSL 1.1 or 3.x
The
UseSystemOpenSSLCryptomay still need some work. For now, it is required to selectTlsmatching OS version.It would be interesting to run
pwsh scripts/build.ps1 -Tls openssl3 -UseSystemOpenSSLCryptoon Arch Linux @ManickaPPGO files should be probably re-generated. For now, this depends on original PR.
I had issues liking system OpenSSL 3. It seems like the new OpenSSL has some trickery linking different sources for static and dynamic libraries. Extra rule in
submodules/CMakeLists.txtries to compensate for it. There may be better long term way to solve.