Support ALPN List Change via ConnectionSetConfiguration function #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nibanks I think I made a mistake while creating the branch, there are commits from the main branch. I can create the PR from scratch if you want to. |
nibanks
reviewed
Aug 12, 2022
nibanks
reviewed
Aug 12, 2022
nibanks
reviewed
Aug 12, 2022
nibanks
added
feature request
I think it's fine. When we squash they will disappear. |
nibanks
reviewed
Aug 12, 2022
nibanks
reviewed
Aug 12, 2022
Co-authored-by: Nick Banks <[email protected]>
Co-authored-by: Nick Banks <[email protected]>
nibanks
reviewed
Aug 12, 2022
nibanks
reviewed
Aug 12, 2022
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ithub.com/liveans/msquic into liveans/correct-behavior-alpn-change-2418
|
/azp run ci |
nibanks
approved these changes
Aug 12, 2022
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #2418 and #2959. Correct the behavior on alpn change
Testing
There is an existing test to test this feature.
Documentation
Yes, removed
NewNegotiatedAlpnfrom docs and added this behavior to docs.