Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest QuicTLS test #2104

Closed
wants to merge 1 commit into from
Closed

Latest QuicTLS test #2104

wants to merge 1 commit into from

Conversation

tmshort
Copy link

@tmshort tmshort commented Nov 1, 2021

@nibanks
Copy link
Member

nibanks commented Nov 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nibanks nibanks marked this pull request as draft November 1, 2021 14:16
@nibanks nibanks added Area: Testing Related to test coverage external Proposed by non-MSFT TLS: OpenSSL labels Nov 1, 2021
@nibanks
Copy link
Member

nibanks commented Nov 1, 2021

@tmshort is there something in here that would make openssl slower? The tests on the latest Windows version timed out. (there was another test that failed to configure properly for some reason). I'm rerunning both.

@tmshort
Copy link
Author

tmshort commented Nov 1, 2021

There really aren't that many changes in the branch. Went from commit df92821e31 to 357353d359. In this PR you can see the diffs to the openssl submodule. (File changed indicates (1), but the it's showing the submodule diff)

@tmshort
Copy link
Author

tmshort commented Nov 1, 2021

Are they timing out due to being slow, or errors?
This introduces the possibility of an error when the legacy session ID is used:
quictls/openssl@df92821...357353d#diff-ad8331ef7b6455d502e8ad14077f12dfd78ee38d79be0227f2c99a8a2eafd8a5R1599

Otherwise, the changes are minimal/innocuous.

@nibanks
Copy link
Member

nibanks commented Nov 1, 2021

Are they timing out due to being slow, or errors?

It seemed to be just general slowness. The tests were all passing still.

@tmshort
Copy link
Author

tmshort commented Nov 1, 2021

Odd. You can see for yourself what there really should've have been anything significant performance-wise... hmmm

@nibanks
Copy link
Member

nibanks commented Nov 1, 2021

Well, maybe it was just a one-off. The tests all passed on rerun. I'd say your quictls changes should be fine.

@tmshort tmshort closed this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Related to test coverage external Proposed by non-MSFT TLS: OpenSSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants