Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Duplicate Stream Read Shutdowns #1822

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Jul 15, 2021

Fixes #1821. Updates the stream abort receive code path to ignore duplicate calls (don't overwrite/change original error code). Also adds test case to validate.

@nibanks nibanks added the Area: Core Related to the shared, core protocol logic label Jul 15, 2021
@nibanks nibanks requested a review from a team as a code owner July 15, 2021 13:50
@nibanks nibanks merged commit 50cf8c5 into main Jul 15, 2021
@nibanks nibanks deleted the nibanks/ignore-duplicate-read-shutdowns branch July 15, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsequent call to StreamShutdown(ABORT_RECEIVE) seems to overwrite the first passed error code
2 participants