add barrier missing between producer submit and needpoke check (#4593)

* add barrier missing between producer submit and needpoke check * submit tx ring only if prod > 0
microsoft · Oct 8, 2024 · ae550a2 · ae550a2
1 parent bdb85ee
commit ae550a2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/platform/datapath_raw_xdp_win.c b/src/platform/datapath_raw_xdp_win.c
@@ -1697,9 +1697,9 @@ CxPlatXdpTx(
         ProdCount++;
     }
 
-    if (ProdCount > 0 ||
+    if ((ProdCount > 0 && (XskRingProducerSubmit(&Queue->TxRing, ProdCount), TRUE)) ||
         (CompCount > 0 && XskRingProducerReserve(&Queue->TxRing, MAXUINT32, &TxIndex) != Queue->TxRing.Size)) {
-        XskRingProducerSubmit(&Queue->TxRing, ProdCount);
+        MemoryBarrier();
         if (Xdp->TxAlwaysPoke || XskRingProducerNeedPoke(&Queue->TxRing)) {
             XSK_NOTIFY_RESULT_FLAGS OutFlags;
             QUIC_STATUS Status = Xdp->XdpApi->XskNotifySocket(Queue->TxXsk, XSK_NOTIFY_FLAG_POKE_TX, 0, &OutFlags);