Skip to content

Fix assert declaration & add a compile test #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2024
Merged

Fix assert declaration & add a compile test #303

merged 3 commits into from
May 20, 2024

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented May 18, 2024

No description provided.

@chhwang chhwang linked an issue May 18, 2024 that may be closed by this pull request
[Bug] __assert_fail declaration in mscclpp breaks "assert()" usage in host functions. #302
Closed
@chhwang chhwang requested a review from Binyang2014 May 18, 2024 22:18
@chhwang chhwang mentioned this pull request May 18, 2024
Closed
@chhwang chhwang enabled auto-merge (squash) May 19, 2024 22:19
@chhwang chhwang merged commit f76eae4 into main May 20, 2024
15 checks passed
@chhwang chhwang deleted the chhwang/fix-assert branch May 20, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Binyang2014 Binyang2014 Binyang2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] __assert_fail declaration in mscclpp breaks "assert()" usage in host functions.
2 participants
@chhwang @Binyang2014