Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet copy for IB #109

Merged
merged 35 commits into from
Jun 28, 2023
Merged

Packet copy for IB #109

merged 35 commits into from
Jun 28, 2023

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Jun 15, 2023 •
edited
Loading

  • Extend channels to support LL with IB
  • Rename classes and interfaces

@chhwang chhwang force-pushed the chhwang/ib-pkt-cpy branch from 6a2e3bc to 21bd57b Compare June 19, 2023 07:25
@chhwang chhwang force-pushed the chhwang/ib-pkt-cpy branch from 21bd57b to fe28794 Compare June 19, 2023 09:11
@chhwang chhwang marked this pull request as ready for review June 25, 2023 04:48
@chhwang chhwang mentioned this pull request Jun 25, 2023
Closed
@chhwang chhwang marked this pull request as draft June 26, 2023 13:53
@saeedmaleki saeedmaleki marked this pull request as ready for review June 27, 2023 22:59
@chhwang chhwang enabled auto-merge (squash) June 28, 2023 02:53
saeedmaleki
saeedmaleki suggested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@saeedmaleki saeedmaleki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes are required.

include/mscclpp/poll.hpp Show resolved Hide resolved
src/debug.cc Outdated Show resolved Hide resolved
src/include/debug.h Outdated Show resolved Hide resolved
include/mscclpp/packet.hpp Outdated Show resolved Hide resolved
Binyang2014
Binyang2014 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code structure much clear than before!

test/mscclpp-test/common.cc Show resolved Hide resolved
test/mscclpp-test/common.cc Outdated Show resolved Hide resolved
@chhwang chhwang merged commit 6ec585f into main Jun 28, 2023
@chhwang chhwang deleted the chhwang/ib-pkt-cpy branch June 28, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeedmaleki saeedmaleki saeedmaleki approved these changes

@Binyang2014 Binyang2014 Binyang2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chhwang @Binyang2014 @saeedmaleki