New rule for non-teminated string in yaml

microsoft · Oct 3, 2018 · 0c23914 · 0c23914
1 parent 66b5497
commit 0c23914
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/yaml/yaml.test.ts b/src/yaml/yaml.test.ts
@@ -145,6 +145,23 @@ testTokenization('yaml', [
 		}]
 	}],
 
+	//Strings
+	[{
+		line: '\'test\'',
+		tokens: [
+			{ startIndex: 0, type: 'string.ts' },
+			{ startIndex: 5, type: 'string.ts' },
+		]
+	}],
+
+	[{
+		line: '\'\'\'',
+		tokens: [
+			{ startIndex: 0, type: 'string.yaml' },
+			{ startIndex: 2, type: 'string.invalid.yaml' },
+		]
+	}],
+
 	// Block Scalar
 	[{
 		line: '>',

diff --git a/src/yaml/yaml.ts b/src/yaml/yaml.ts
@@ -202,6 +202,8 @@ export const language = <ILanguage>{
 
 		// Start Flow Scalars (quoted strings)
 		flowScalars: [
+			[/"([^"\\]|\\.)*$/, 'string.invalid'],
+			[/'([^'\\]|\\.)*$/, 'string.invalid'],
 			[/"/, 'string', '@string."'],
 			[/'/, 'string', '@string.\'']
 		],