-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CsWinRT projection #9976
base: release/2.8
Are you sure you want to change the base?
Add CsWinRT projection #9976
Conversation
Update to ESRP task V5 which eliminates secret usage. Parameter values to the task can be controlled by this library https://microsoft.visualstudio.com/WinUI/_apps/hub/ms.vss-distributed-task.hub-library?itemType=VariableGroups&view=VariableGroupView&variableGroupId=5612&path=WinUI2-Signing This currently points to WindowsAppSDK's ESRP configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Left a few updates following the latest changes in CsWinRT/tooling 🙂
build/NuSpecs/MUXControls.nuspec
Outdated
@@ -28,6 +41,10 @@ | |||
<file target="lib\uap10.0\Microsoft.UI.Xaml\Themes" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml\Generic.xaml"/> | |||
<file target="lib\uap10.0\Design" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml.Design\Microsoft.UI.Xaml.design.dll"/> | |||
|
|||
<file target="lib\net8.0-windows10.0.22621.0\Microsoft.UI.Xaml.Projection.dll" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml.Projection\Microsoft.UI.Xaml.Projection.dll" /> | |||
<file target="lib\net8.0-windows10.0.22621.0\Microsoft.UI.Xaml\Themes" src="$BUILDOUTPUT$\$BUILDFLAVOR$\$BUILDARCH$\Microsoft.UI.Xaml\Generic.xaml"/> | |||
<file target="lib\net8.0-windows10.0.22621.0" src="Intellisense\Microsoft.UI.Xaml.xml"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to match the name of this .xml to the projection .dll (same for the other .nuspec files):
<file target="lib\net8.0-windows10.0.22621.0" src="Intellisense\Microsoft.UI.Xaml.xml"/> | |
<file target="lib\net8.0-windows10.0.22621.0\Microsoft.UI.Xaml.Projection.xml" src="Intellisense\Microsoft.UI.Xaml.xml"/> |
.NET 9 and Visual Studio 2022 version 17.12 have been released, and UWP.NET 9 has been supported. Is the Projection of WinUI 2 yet to be updated -------------------------------------------------.NET 9 和 Visual Studio 2022 17.12 正式版已经发布了,已经支持了 UWP .NET 9,想问一下 WinUI 2 的 Projection 还没有更新吗 |
<DisableRuntimeMarshalling>true</DisableRuntimeMarshalling> | ||
<EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
<WindowsSdkPackageVersion>10.0.22621.54</WindowsSdkPackageVersion> | ||
<UseRidGraph>true</UseRidGraph> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should no longer need UseRidGraph
here in VS 17.12 stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the CI has been updated with the .NET 9 SDK yet. Let's just keep this for now just in case.
Microsoft.UI.Xaml.Projection.dll 文件的公司名称写错了,应该是 Microsoft Corporation,而不是 Microsoft.UI.Xaml.Projection。 ---------------------------------------------------The company name of the Microsoft.UI.Xaml.Projection.dll file is misspelled and should be Microsoft Corporation, not Microsoft.UI.Xaml.Projection. |
@Gaoyifei1011 thank you for trying this out!
|
All right. Thank you for your correction |
No description provided.