Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when scrolling nested ItemsRepeaters #152

Merged
merged 5 commits into from
Jan 24, 2019
Merged

Fix crash when scrolling nested ItemsRepeaters #152

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd16853
fix add pin bug
Jan 8, 2019
c445dd1
Merge remote-tracking branch 'origin/master' into user/ranjeshj/addpi…
Jan 23, 2019
5ab041e
update fix and also fix unrealiable canbringintoviewelements test
Jan 23, 2019
00b9130
fix unpinning case
Jan 23, 2019
32f4289
kicking the checks again since teh licence/cla check seems to be stuck.
Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dev/Repeater/ViewManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ void ViewManager::UpdatePin(const winrt::UIElement& element, bool addPin)
repeater.InvalidateMeasure();
}
}

break;
ranjeshj marked this conversation as resolved.
Show resolved Hide resolved
}

child = parent;
Expand Down