Skip to content

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Aug 30, 2025

What does this PR do?

Synchronized with main@14522b16

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
    • Spelling check passes: .\eng\common\spelling\Invoke-Cspell.ps1
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated README.md documentation
    • Updated command list in /docs/azmcp-commands.md
    • Updated test prompts in /docs/e2eTestPrompts.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • 👉 For Community (non-Azure team member) PRs:
    • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
    • Manual tests run: added comment /azp run azure - mcp to run Live Test Pipeline

Copilot AI review requested due to automatic review settings August 30, 2025 00:19
@hallipr hallipr requested a review from a team as a code owner August 30, 2025 00:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request synchronizes the eng/common directory with the latest changes from the azure-sdk-tools repository. The sync includes new functionality for release plan completion, resource management improvements, and updated test scripts.

Key changes:

  • New release plan completion functionality with automated marking of package releases
  • Enhanced resource cleanup capabilities with support for AI/Cognitive Services resources
  • Updated test resource provisioning to handle different tenant authentication scenarios

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
eng/common/scripts/Mark-ReleasePlanCompletion.ps1 New script for marking release plan completion
eng/common/scripts/Helpers/Resource-Helpers.ps1 Enhanced resource cleanup with AI services support
eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 New DevOps helper functions for release plan management
eng/common/pipelines/templates/steps/mark-release-completion.yml New pipeline step template for release completion
eng/common/instructions/azsdk-tools/*.instructions.md Multiple instruction files for various Azure SDK tools
eng/common/TestResources/New-TestResources.ps1 Updated test resource provisioning with improved tenant handling

@hallipr hallipr enabled auto-merge (squash) August 30, 2025 00:51
@hallipr hallipr disabled auto-merge September 2, 2025 23:32
@hallipr hallipr merged commit 8b36b89 into main Sep 2, 2025
25 checks passed
@hallipr hallipr deleted the eng-common-sync branch September 2, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants