Fix VSIX signing and add "Verify VSIX Signing" step #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcolin7
requested review from
JasonYeMSFT,
KarishmaGhiya,
conniey,
hallipr,
sandeep-sen,
tmeschter and
wbreza
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the VSIX signing process by correcting the pattern matching for .p7s signature files during release builds.
- Updated the file pattern from
*.signature.p7sto**/*.signature.p7sto enable recursive directory search - Ensures that signature files in subdirectories are properly included in the signing process
vcolin7
changed the title
hallipr
reviewed
Aug 29, 2025
JonathanCrd
approved these changes
Sep 2, 2025
feiskyer
pushed a commit
to feiskyer/microsoft-mcp
that referenced
this pull request
Sep 8, 2025
* Refactor code to ensure consistent formatting and improve readability across multiple files - Added missing newlines at the end of several C# files to comply with coding standards. - Reorganized using directives for better clarity in various service and model files. - Enhanced code readability by breaking long lines and ensuring proper indentation. - Updated tests to maintain consistency with the refactored code structure. - Introduced a .gitattributes file to manage line endings and text attributes for various file types. * Add copyright and license comments to EnvironmentVariableHelpers.cs
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
* Fixed VSIX signing pattern matching for .p7s files * Added a Verify VSIX Signing step * Changed file extension to verify signature of * Moved VSIX verification to the VSIX .yml file * Fixed VSIX verification * Add 'fname' to cspell configuration --------- Co-authored-by: Vinay Gera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed pattern matching for .p7s files for VSIX signing during release and added a verify step.
GitHub issue number?
N/A
Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/docs/e2eTestPrompts.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptscrypto mining, spam, data exfiltration, etc.)/azp run azure - mcpto run Live Test Pipeline