Skip to content

Conversation

@conniey
Copy link
Member

@conniey conniey commented Oct 21, 2025

What does this PR do?

Moves ServerStarted telemetry until after host services have started. They were not being published to AppInsights before.

image

GitHub issue number?

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the ServerStarted telemetry emission to occur after the host services have started, ensuring that telemetry is properly published to AppInsights. Previously, the telemetry was being logged before the host was started, which prevented it from being sent.

  • Reordered the host startup sequence to emit telemetry after host.StartAsync() completes
  • Ensures telemetry service is fully initialized before logging startup metrics

@joshfree joshfree added this to the 2025-10 milestone Oct 21, 2025
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Oct 21, 2025
@conniey conniey enabled auto-merge (squash) October 21, 2025 18:30
@conniey conniey force-pushed the serverstarted-move branch from 7e06631 to 6de6279 Compare October 21, 2025 21:53
@conniey conniey merged commit 539a5a9 into microsoft:main Oct 21, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Oct 21, 2025
@conniey conniey deleted the serverstarted-move branch October 21, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants