Fix MySQL multiple statements validation logic #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramnov
requested review from
JonathanCrd,
alzimmermsft,
fanyang-mono,
jongio,
joshfree,
vukelich and
xiangyan99
There was a problem hiding this comment.
Pull Request Overview
This PR fixes MySQL query validation logic that was incorrectly flagging valid queries containing semicolons as invalid. The fix updates regex patterns to properly detect dangerous SQL injection patterns and multiple statements while allowing legitimate single statements with trailing semicolons.
- Updated regex patterns to distinguish between legitimate single statements with semicolons and actual multiple statements
- Modified dangerous pattern detection to focus on semicolons followed by injection keywords rather than any semicolon
- Added comprehensive test cases covering edge cases with semicolons and comments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MySqlService.cs | Updated validation logic with improved regex patterns for detecting multiple statements and SQL injection attempts |
| MySqlServiceQueryValidationTests.cs | Added test cases for valid queries with semicolons and additional test coverage for multiple statement detection |
...ols.MySql/tests/Azure.Mcp.Tools.MySql.UnitTests/Services/MySqlServiceQueryValidationTests.cs
Show resolved
Hide resolved
ramnov
changed the title
mattkohnms
reviewed
Sep 4, 2025
mattkohnms
approved these changes
Sep 4, 2025
alzimmermsft
reviewed
Sep 4, 2025
jongio
approved these changes
Sep 4, 2025
alzimmermsft
approved these changes
Sep 4, 2025
feiskyer
pushed a commit
to feiskyer/microsoft-mcp
that referenced
this pull request
Sep 8, 2025
* Adds support for Azure Database for PostgreSQL
- Adds support for Azure Database for PostgreSQL - Flexible Server.
- Implements the following PostgreSQL commands:
- Server
- List
- GetConfig
- GetParam
- Database
- List
- Query
- Table
- List
- GetSchema
- Adds service and interface for PostgreSQL.
- Adds commands and arguments for PostgreSQL
- Registers the new commands in the CommandFactory.
- Registers the new service to start during service initialization.
- Updates the ArgumentDefinitions to include PostgreSQL commands.
- Updates the AzureMcp project file to include the new dependencies.
Notes:
- Inherits from SubscriptionCommand
- Adds resource group explicitly to options and arguments.
* Adds tests for Azure Database for PostgreSQL
* Update README and azmcp docs with PostgreSQL capabilities.
* Rebase, addresses review comments & refactor base classes
- Update to work with the rebased code.
- Add PostgresJsonContext
- Remove explicit validations.
- Change the commandline arguments to give more context (pg => postgres)
- Simplify command line usage (get-schema => schema)
- Add JsonPropertyName
- Add more tests for validating missing parameters.
- Simplify logic in PG query & server config.
- Fix commmand names
- Use common BaseAzureService credential
- Refactor server and database to use common base classes.
- Update docs
- Run dotnet format.
* Remove the extra line
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
* Fix MySQL query validation logic * remove duplicate unit test * update logic * dotnet format * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
MySQL was incorrectly flagging proper query like "SELECT * from users;" as invalid. Updated logic to detect this properly. Added extra unit tests.
GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/docs/e2eTestPrompts.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptscrypto mining, spam, data exfiltration, etc.)/azp run azure - mcpto run Live Test Pipeline