Skip to content

Conversation

@chidozieononiwu
Copy link
Member

What does this PR do?

Updates Pack-Nuget script to use Microsoft icon when no Package Icon is specified.

GitHub issue number?

NA

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the NuGet package creation process to use Microsoft's icon as the default fallback when no specific package icon is defined, while allowing individual servers to specify their own icons (like Azure MCP Server using azureicon.png).

  • Modifies Pack-Nuget script to dynamically select package icons based on project properties
  • Adds Azure-specific icon configuration to the Azure MCP Server project
  • Replaces hardcoded azure icon references with dynamic package icon path resolution

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
servers/Azure.Mcp.Server/src/Azure.Mcp.Server.csproj Adds PackageIcon property and includes azureicon.png in the package
eng/scripts/Pack-Nuget.ps1 Updates script to use dynamic package icon selection with Microsoft icon as fallback

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server Sep 26, 2025
@chidozieononiwu chidozieononiwu merged commit 766a851 into main Sep 26, 2025
44 checks passed
@chidozieononiwu chidozieononiwu deleted the update-nuget-package-icons branch September 26, 2025 22:50
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Sep 26, 2025
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Sep 27, 2025
* Add Microsoft Icon

* Use Azure or Microsoft icon for nuget packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants