Adds support to proxy MCP capabilities when child servers leverage sampling or elicitation #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
requested review from
JonathanCrd,
conniey,
Copilot,
jairmyree,
jongio,
joshfree,
tmeschter and
vukelich
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for proxying MCP sampling and elicitation capabilities when child servers leverage these features. Previously, when running in namespace mode or using built-in external servers like documentation and azd, these MCP capabilities were not properly forwarded.
- Consolidates client option creation logic into the base class
- Adds proper capability forwarding for sampling and elicitation features
- Includes comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| servers/Azure.Mcp.Server/CHANGELOG.md | Documents the feature addition for version 0.8.3 |
| core/Azure.Mcp.Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ToolLoading/BaseToolLoaderTests.cs | Comprehensive test suite covering capability forwarding scenarios |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/SingleProxyToolLoader.cs | Removes duplicate CreateClientOptions method |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/ServerToolLoader.cs | Removes duplicate CreateClientOptions method |
| core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/BaseToolLoader.cs | Adds shared CreateClientOptions method with capability forwarding logic |
...Core/tests/Azure.Mcp.Core.UnitTests/Areas/Server/Commands/ToolLoading/BaseToolLoaderTests.cs
Show resolved
Hide resolved
core/Azure.Mcp.Core/src/Areas/Server/Commands/ToolLoading/BaseToolLoader.cs
Show resolved
Hide resolved
jongio
approved these changes
Sep 25, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure MCP Server
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
…mpling or elicitation (microsoft#581) When running in namespace mode or leveraging built in external servers like documentation and azd MCP features for sampling and elicitation are not enabled. This PR correctly sets the sampling and elicitation capabilities when generating the MCP clients and forwards requests along to the original MCP host..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When running in
namespacemode or leveraging built in external servers likedocumentationandazdMCP features for sampling and elicitation are not enabled.This PR correctly sets the sampling and elicitation capabilities when generating the MCP clients and forwards requests along to the original MCP host..
GitHub issue number?
Resolves #214
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)