Improve error message for missing parameters in Kusto commands #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prvavill
requested review from
a team,
danield137 and
xiangyan99
as code owners
prvavill
requested review from
KarishmaGhiya,
alzimmermsft,
Copilot,
fanyang-mono,
hallipr,
jongio and
sandeep-sen
There was a problem hiding this comment.
Pull Request Overview
This PR enhances parameter validation by providing parameter names in exception messages. It adds a new overloaded method ValidateRequiredParameters that accepts named parameters as tuples, allowing for more descriptive error messages that include the parameter name when validation fails.
Key changes:
- Added overloaded
ValidateRequiredParametersmethod that accepts named parameters as tuples - Updated all
ValidateRequiredParameterscalls inKustoServiceto use the new named parameter format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/Azure.Mcp.Core/src/Services/Azure/BaseAzureService.cs | Added new overloaded ValidateRequiredParameters method that accepts named parameters and provides parameter names in exception messages |
| tools/Azure.Mcp.Tools.Kusto/src/Services/KustoService.cs | Updated all ValidateRequiredParameters calls to use the new named parameter format with nameof() operator |
Co-authored-by: Copilot <[email protected]>
vcolin7
reviewed
Sep 25, 2025
…hub.com/microsoft/mcp into user/prvavill/handle_missing_param_name
vcolin7
changed the title
vcolin7
approved these changes
Sep 26, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
…soft#575) * Handling missing param name exception with parameter name * Update core/Azure.Mcp.Core/src/Services/Azure/BaseAzureService.cs Co-authored-by: Copilot <[email protected]> * fix to throw all missing params at once --------- Co-authored-by: Copilot <[email protected]>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
when required parameter is not provided get cluster details tool, client sees error and the error info does not clearly say which parameter is missing
GitHub issue number?
#549
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline