Skip to content

Conversation

@anannya03
Copy link
Contributor

@anannya03 anannya03 commented Sep 19, 2025

What does this PR do?

azmcp-eventgrid-events-publish - Publish custom events to Event Grid topics for event-driven architectures. This tool sends structured event data to Event Grid topics with schema validation and delivery guarantees for downstream subscribers. Returns publish operation status.

  • topic and event-data is mandatory.
  • event-schema can be either 'EventGrid', 'CloudEvent' or custom-type.

GitHub issue number?

#297

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@anannya03

This comment was marked as resolved.

@joshfree joshfree added this to the 2025-09 milestone Sep 19, 2025
@joshfree joshfree added the server-Azure.Mcp Azure.Mcp.Server label Sep 19, 2025
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Sep 19, 2025
@anannya03 anannya03 force-pushed the publish-eventgrid-events branch from 20f6579 to 6fc771a Compare September 23, 2025 06:06
@anannya03 anannya03 marked this pull request as ready for review September 23, 2025 07:20
@anannya03 anannya03 requested a review from a team as a code owner September 23, 2025 07:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new MCP tool for publishing custom events to Azure Event Grid topics. The tool supports multiple event schemas (EventGrid, CloudEvents, Custom) and enables event-driven architectures by providing structured event publishing capabilities with delivery guarantees.

Key changes include:

  • New EventsPublishCommand for publishing events to Event Grid topics
  • Support for EventGrid, CloudEvents, and Custom schema formats
  • Comprehensive unit and live tests for event publishing scenarios
  • Event schema validation and parsing logic

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
EventsPublishCommand.cs Main command implementation for publishing events to Event Grid topics
EventGridService.cs Service layer implementation with event parsing and publishing logic
EventsPublishCommandTests.cs Comprehensive unit tests covering various event publishing scenarios
EventGridCommandTests.cs Live integration tests for event publishing functionality
EventGridEventSchema.cs Model for EventGrid event schema with JSON serialization attributes
EventPublishResult.cs Result model for event publishing operations
Various other files Supporting options, setup, and configuration changes

@anannya03 anannya03 force-pushed the publish-eventgrid-events branch from a828449 to 9990c21 Compare September 24, 2025 20:12
@anannya03 anannya03 enabled auto-merge (squash) September 25, 2025 07:26
@anannya03 anannya03 requested a review from a team as a code owner September 25, 2025 20:00
@anannya03 anannya03 force-pushed the publish-eventgrid-events branch from 2fac4f0 to 5233309 Compare September 25, 2025 20:02
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt! ty

@anannya03 anannya03 merged commit 8b3fae3 into microsoft:main Sep 25, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Sep 25, 2025
colbytimm pushed a commit to colbytimm/microsoft-mcp that referenced this pull request Sep 27, 2025
* merge conflict 1

* merge conflict 2

* merge conflict 3

* merge conflict 5

* merge conflict 6

* dotnet format

* fixed with httpstatuscode

* cleaned up a little

* review comment

* review comment

* Addressed review comments

* Addressed review comments except POJO

* Refactored using POJO instead of JSON object traversal

* defined loggerFactory

* Addressed review comments

* Removed additional validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server-Azure.Mcp Azure.Mcp.Server

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants