[No review] try native package build and publish #49
Conversation
anuchandy
requested review from
JasonYeMSFT,
JonathanCrd,
KarishmaGhiya,
msalaman,
sandeep-sen,
tmeschter and
wbreza
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for building and publishing native (AOT) packages alongside the existing dotnet packages for the Azure MCP Server. The changes enable dual-package distribution with separate native and dotnet variants.
- Modifies the build pipeline to organize artifacts into separate dotnet and native directories
- Updates the packaging workflow to handle both package types with separate packing tasks
- Enhances the publishing template to support both @azure/mcp and @azure/mcp-native packages
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/pipelines/templates/jobs/build.yml | Updates native build output path to staging directory |
| eng/pipelines/templates/jobs/sign-and-pack.yml | Adds artifact organization logic and separate packing tasks for dotnet and native packages |
| eng/pipelines/templates/steps/publish-to-dev-feed.yml | Updates file discovery and documentation to support both package variants |
| -OutputPath '$(Build.ArtifactStagingDirectory)/packed' | ||
| -ArtifactsPath '$(Build.ArtifactStagingDirectory)/topack/native' | ||
| -OutputPath '$(Build.ArtifactStagingDirectory)/packed/native' | ||
| -Version '$(Version)' |
There was a problem hiding this comment.
The -IsNative parameter is introduced without documentation or context. Consider adding a comment explaining what this parameter does in the native packaging process.
| -Version '$(Version)' | |
| -Version '$(Version)' | |
| # The -IsNative parameter signals Pack-Modules.ps1 to package native modules instead of dotnet modules. |
| exit 1 | ||
| } | ||
| $tgzFiles = $tgzDotnetFiles + $tgzNativeFiles |
There was a problem hiding this comment.
[nitpick] The logic for combining dotnet and native files could be simplified. Consider extracting the file discovery logic into a helper function to reduce code duplication and improve readability.
anuchandy
force-pushed
the
dual-ship-only-azmcp
branch
from
60d18d6 to
5e4d79d
Compare
anuchandy
force-pushed
the
dual-ship-only-azmcp
branch
from
5e4d79d to
e34466f
Compare
* Add aka.ms message to exceptions. * Return command info with suggested values. * Fix test failure and documentation
2 participants
What does this PR do?
[Provide a clear, concise description of the changes][Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/docs/e2eTestPrompts.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptscrypto mining, spam, data exfiltration, etc.)/azp run azure - mcpto run Live Test Pipeline