Add azmcp sql server create/delete/show commands and unit tests#312
Merged
ericshape merged 17 commits intomicrosoft:mainfrom Sep 15, 2025
Merged
Add azmcp sql server create/delete/show commands and unit tests#312ericshape merged 17 commits intomicrosoft:mainfrom
azmcp sql server create/delete/show commands and unit tests#312ericshape merged 17 commits intomicrosoft:mainfrom
Conversation
jongio
requested changes
Sep 5, 2025
tools/Azure.Mcp.Tools.Sql/src/Commands/Server/ServerCreateCommand.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.Sql/src/Commands/Server/ServerCreateCommand.cs
Outdated
Show resolved
Hide resolved
tools/Azure.Mcp.Tools.Sql/src/Commands/Server/ServerCreateCommand.cs
Outdated
Show resolved
Hide resolved
ericshape
requested review from
alzimmermsft,
conniey,
Copilot,
fanyang-mono,
hallipr,
jongio,
tmeschter and
wbreza
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive SQL server management capabilities to the Azure MCP Tools, implementing create, show, and delete commands for Azure SQL servers along with their corresponding unit tests.
- Implements three new SQL server commands: create, delete, and show operations
- Adds comprehensive unit tests covering various scenarios including validation, error handling, and edge cases
- Updates documentation and command listings to reflect the new functionality
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| SqlSetup.cs | Registers the new server commands in the command hierarchy |
| ISqlService.cs | Adds interface definitions for server CRUD operations |
| SqlService.cs | Implements server create, show, and delete functionality using Azure ARM clients |
| SqlOptionDefinitions.cs | Defines command-line options for server operations |
| ServerCreateCommand.cs | Command implementation for creating SQL servers |
| ServerDeleteCommand.cs | Command implementation for deleting SQL servers with safety warnings |
| ServerShowCommand.cs | Command implementation for retrieving server details |
| Models/SqlServer.cs | Data model representing SQL server properties |
| Various test files | Comprehensive unit tests for all three commands |
| Documentation files | Updates to README, command documentation, and test prompts |
tools/Azure.Mcp.Tools.Sql/src/Commands/Server/ServerDeleteCommand.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
xiangyan99
reviewed
Sep 15, 2025
xiangyan99
reviewed
Sep 15, 2025
tools/Azure.Mcp.Tools.Sql/src/Commands/Server/ServerCreateCommand.cs
Outdated
Show resolved
Hide resolved
jongio
approved these changes
Sep 15, 2025
Contributor
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run mcp - pullrequest - live |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@xiangyan99 I have resloved all comments, can I have a re-approval from your side to merge? Thanks~ |
xiangyan99
approved these changes
Sep 15, 2025
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Sep 27, 2025
…crosoft#312) * add sql server create/delete/show command impl * fix spell issue * add docs to the md files * Add live tests for SQL server create, show, and delete * fix live test * address commends and rebase * fix server crud live test * delete live test due to test sub id cannot get resource * Update CHANGELOG.md * Update docs/azmcp-commands.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tools/Azure.Mcp.Tools.Sql/src/Services/SqlService.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * address comment * fix the build error * update tool metadata info --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
azmcp sql server create/delete/showcommands and unit testsazmcp sql server createazmcp sql server deleteazmcp sql server showGitHub issue number?
#239
Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/docs/e2eTestPrompts.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptscrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline