Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Use multi-thread to index #13

Merged
merged 2 commits into from
Apr 18, 2019
Merged

perf: Use multi-thread to index #13

merged 2 commits into from
Apr 18, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Apr 18, 2019

Resolve #12

@jdneo jdneo added this to the 0.1.5 milestone Apr 18, 2019
@jdneo jdneo requested a review from yaohaizh April 18, 2019 02:14
yaohaizh
yaohaizh approved these changes Apr 18, 2019
View reviewed changes
com.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java
DiagnosticVisitor diagnosticVisitor = new DiagnosticVisitor(currentContext, cu);
diagnosticVisitor.enlist();
completableFutures.add(CompletableFuture.runAsync(() -> {
diagnosticVisitor.enlist();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API is different from other visitor? Should make them consistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking: #14

@jdneo jdneo merged commit 90ba055 into master Apr 18, 2019
@jdneo jdneo deleted the cs/multi-thread branch April 18, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaohaizh yaohaizh yaohaizh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.5
Development

Successfully merging this pull request may close these issues.

Using multi-thread to index
2 participants
@jdneo @yaohaizh