Pin external deps to ensure explicit updates to lage bundle #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for peppy-praline-1c3272 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ecraig12345
force-pushed
the
dep-versions
branch
from
777ee48
to
e17bec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lage bundles its dependencies, so if we use the standard approach of
^versions for external dependencies, this can allow implicit updates (via the lock file) which won't immediately trigger a new release, and won't be noted in the release notes when a new version does include them. This means that if a dep introduces a bug, and it's only discovered in another repo, it's extremely hard to track down how it was introduced.Probably the safest workaround is to pin all external dependencies that updates are explicit and included in the release notes. (Exception is
glob-hasher, which is a runtime dep since it ships binaries.)This has minor downsides for cloudpack packages which depend on lage packages (potential for duplicate deps), but the benefit for core lage scenarios is worth it.