Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows, skip test_conv_2d_no_bias due to Jax dependency #661

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

cgravill
Copy link
Contributor

def conv_2d_no_bias(x, weights, ksizes, strides, paddings):
y = jax.lax.conv_general_dilated(
x,
weights,
strides,
paddings,
dimension_numbers=('NCHW', 'OIHW', 'NCHW') # the same as pytorch / onnx
)
print(f"conv_2d shape: {y.shape}")
return y

jax-ml/jax#5795

It looks like we could build Jax ourselves on Windows if needed.

Copy link
Contributor

@awf awf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Maybe make an issue to enable this, but not high pri.

@cgravill cgravill merged commit 0bdedff into master Mar 19, 2021
@cgravill cgravill deleted the cogravil/skip_jax_tests_Windows branch March 19, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants