Skip to content

Update requirements #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Jul 12, 2024
Merged

Update requirements #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
steps:
- task: UsePythonVersion@0
inputs:
versionSpec: 3.11
versionSpec: 3.12
- bash: |
set -ev

Expand Down
6 changes: 2 additions & 4 deletions knack/help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,8 +464,7 @@ def _layout_items(items):
'line_len': line_len
}
layout['summary'] = layout['summary'].replace('\n', ' ')
if line_len > self.max_line_len:
self.max_line_len = line_len
self.max_line_len = max(line_len, self.max_line_len)
Copy link
Member Author

@jiasli jiasli Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To solve pylint error:

> pylint knack --rcfile=.pylintrc --reports n --disable I0013
************* Module knack.help
knack\help.py:467:16: R1731: Consider using 'max_line_len = max(max_line_len, line_len)' instead of unnecessary if block (consider-using-max-builtin)
knack\help.py:589:16: R1731: Consider using 'max_line_len = max(max_line_len, line_len)' instead of unnecessary if block (consider-using-max-builtin)

layouts.append(layout)
return layouts

Expand Down Expand Up @@ -586,8 +585,7 @@ def _layout_items(items):
'group_name': c.group_name,
'line_len': line_len
}
if line_len > self.max_line_len:
self.max_line_len = line_len
self.max_line_len = max(line_len, self.max_line_len)
layouts.append(layout)
return layouts

Expand Down
14 changes: 7 additions & 7 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
argcomplete==3.1.1
flake8==6.0.0
argcomplete==3.4.0
flake8==7.1.0
jmespath==1.0.1
packaging==23.1
Pygments==2.15.1
pylint==2.17.4
pytest==7.4.0
packaging==24.1
Pygments==2.18.0
pylint==3.2.5
pytest==8.2.2
PyYAML
tabulate==0.9.0
vcrpy==5.0.0
vcrpy==6.0.1