Skip to content

fix default value set for bool type #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jiashuo Li (jiasli) merged 8 commits into from
Jul 20, 2023
Merged

fix default value set for bool type #273

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5070422
fix default value set for bool type
AllyW Jul 19, 2023
a7b04c8
add default bool with is_default set
AllyW Jul 19, 2023
80ae053
set all default values
AllyW Jul 19, 2023
089974a
skip bool default instance
AllyW Jul 19, 2023
3764072
add style skip
AllyW Jul 20, 2023
857f32b
change funca
AllyW Jul 20, 2023
b560be9
use short link
AllyW Jul 20, 2023
ccfe92b
adjust comment
AllyW Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion knack/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,12 @@ def update_argument(self, param_name, argtype):
# that coincides with the default
if isinstance(arg_default, str):
arg_default = DefaultStr(arg_default)
elif isinstance(arg_default, int):
elif type(arg_default) is int: # pylint: disable=unidiomatic-typecheck
Comment thread
AllyW marked this conversation as resolved.
Outdated
# use type here is because:
# 1) bool is subclass of int so isinstance(True, int) cannot distinguish between int and bool
# 2) bool is not extendable according to
# https://stackoverflow.com/questions/2172189/why-i-cant-extend-bool-in-python,
# so bool's is_default is ignored for now
arg_default = DefaultInt(arg_default)
# update the default
if arg_default:
Expand Down