Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Jan 27, 2021

Drop Python 2 compatible code by:

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 27, 2021

Drop Python 2

Copy link
Collaborator

@yonzhan yonzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if not isinstance(output, text_type):
output = u(str(output))
if not isinstance(output, str):
output = str(output)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unicode is already the default in Python 3.

@jiasli jiasli requested a review from kairu-ms January 29, 2021 04:33
@jiasli jiasli merged commit 76e100a into microsoft:master Feb 2, 2021
@jiasli jiasli deleted the drop-py2 branch February 2, 2021 13:02
@jiasli jiasli mentioned this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants