Command suggestion feature from CLI 2.0 #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limingu
approved these changes
May 22, 2019
Member
limingu
left a comment
limingu
left a comment
There was a problem hiding this comment.
I assume that moving this feature to knack to let others use. Do we want to centralize this feature and let the CLI core to use this from knack? So we can remove the duplicate codes in CLI core.
Member
Author
|
@limingu yes, my PR to update the CLI to use this version of knack will remove the duplicate code. |
Member
Author
|
@limingu it turns out that the version in the CLI needs to remain because it is wired for telemetry and has additional logic based on command_source, which is not in knack. But now it means that knack-based CLIs will have the command suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131. Add the feature from Azure CLI where the CLI will try to suggest the closest alternative when the user mistypes a command.