Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use import type for the typescript abstraction library code where relevant #3040

Merged
merged 8 commits into from
Aug 4, 2023
Merged

Use import type for the typescript abstraction library code where relevant #3040

merged 8 commits into from
Aug 4, 2023

Conversation

koros
Copy link
Contributor

@koros koros commented Aug 3, 2023 •
edited by baywet
Loading

fixes #2995

@koros koros requested a review from a team as a code owner August 3, 2023 10:21
baywet
baywet requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • unit test for the writer
  • changelog entry

src/Kiota.Builder/Refiners/AdditionalUsingEvaluator.cs Outdated Show resolved Hide resolved
@koros koros changed the title Use import type for typescript abstraction library where relevant(Draft) Use import type for typescript abstraction library where relevant Aug 3, 2023
@koros koros changed the title Use import type for typescript abstraction library where relevant Use import type for the typescript abstraction library code where relevant Aug 3, 2023
@koros koros changed the title Use import type for the typescript abstraction library code where relevant Use import type for the typescript abstraction library code where relevant Aug 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.2% 95.2% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@koros koros merged commit ff5e089 into main Aug 4, 2023
93 of 94 checks passed
@koros koros deleted the feature/typescript/use-import-type branch August 4, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use import type statements for all other interfaces that are declared elsewhere e.g. the abstraction libraries
3 participants
@koros @andrueastman @baywet