-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce IParseNode Enum methods DynamicallyAccessedMembers scope #202
Reduce IParseNode Enum methods DynamicallyAccessedMembers scope #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @hwoodiwiss
Would you also be able to submit PRs for the serialization libs taking a dependency on IParseNode
? If not, I can probably do that once we merge this one in.
I'm happy to update the Serialization libraries for this |
Also reverts styling changes
I'm going to need to take a deeper look at this, looking at the usage of I'll revert this part of the change for now. |
I think fully supporting AOT compilation is going to need some deeper changes that will likely also require changes to the public API, specifically around |
Please go ahead with the issue. Do you think we should hold to merge this PR to get resolution? or do you believe this PR is already an improvement over the current situation? |
Cool, I'll open something this evening. I think this is still an improvement, it gives a better base going forward, and this was by far the largest producer of trim warnings I saw when compiling AOT, just due to how many times it's used, plus nothing the serialization libraries are doing at the moment requires more than |
Enumerating fields on enums is always trimming/AOT safe. If the T is restricted to be I.e. even if this is |
Alright, thanks everyone for the context! I'll hand it over to @andrueastman for a final review, merge and publish! |
Ahh, okay, that makes sense. I'll amend this to take that into account this evening. Thank you for the info. In which case, after this, the abstractions library should be trimming safe. |
Per microsoft#202 (comment), we know that enumerating an enum here is trimming-safe
Thank you @eerhardt Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
This will need to be manually updated across the other repos that implement IParseNode
fixes #201