policy: validate pod generated name #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redent0r
force-pushed
the
saulparedes/validate_generated_name
branch
from
76a1459 to
eeb8ad2
Compare
manuelh-dev
approved these changes
Mar 17, 2025
danmihai1
approved these changes
Mar 17, 2025
Validate sandbox name using a regex. If the YAML specifies metadata.name, use a regex that exact matches. If the YAML specifies metadata.generateName, use a regex that matches the prefix of the generated name. Signed-off-by: Saul Paredes <[email protected]>
We only use protocols in the tests, so it should be a dev dependency. Signed-off-by: Saul Paredes <[email protected]>
Update samples Signed-off-by: Saul Paredes <[email protected]>
Redent0r
force-pushed
the
saulparedes/validate_generated_name
branch
from
72df3c3 to
c481445
Compare
Author
|
Test results revelead a few failing samples that reveal the sandbox name is used in variable validation too. Force pushed to include a175e12#diff-456165c5b51c7f523a8f6226bab85a095af361c1430c61141d40361fa0a25892R881-R894 and starting a new test run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
Mark on the policy data if a pod is using a generated name. If it is, validate that the policy sandbox name is a suffix of the input sandbox name as expected
Context: see
generateNamein https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.24/#objectmeta-v1-metaupstream PR kata-containers#11012
Test Methodology
test run: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=765084&view=results [3 unexpected failures]
test rerun: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=765316&view=results [pass]